Fixed collapsed function bug with tailwind CSS on mobile version #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I will review this week, apologies but I've been on holiday |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #2228 +/- ##
==============================================
Coverage 89.96% 89.96%
Complexity 2154 2154
==============================================
Files 242 242
Lines 4853 4853
==============================================
Hits 4366 4366
Misses 487 487 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Merged
lrljoe
added a commit
that referenced
this pull request
May 3, 2025
* Link column fix (#2223) * Add handling for From field for "LinkColumn" * Fix styling * Update ChangeLog * docs: add reminder of requirement to use toggle method (#2208) Co-authored-by: Joe <[email protected]> * Update IsNumericFilter.php (#2230) * Link column fix (#2223) (#2224) * Link column fix (#2223) * Add handling for From field for "LinkColumn" * Update ChangeLog * Update IsNumericFilter.php Fixes issues 2229 --------- Co-authored-by: Joe <[email protected]> * Fix styling * Boolean filter for bootstrap (#2244) * Add BooleanFilter option for Bootstrap * Add BS4 Support * Update docs * Fixes for livewire component column (#2245) * Initial Commit * Fix styling * Initial Commit * Fix styling * Adjust test * Fix styling * Use test-livewire-column-component * Additional Tests for LivewireComponentColumn * Fix styling * Add getContents Test * TypeHint/PHPDoc Tidying (#2246) * Fix broken typehints * Minor tweaks to Footer/SecondaryHeader to ensure presence of callback prior to executing * Fix styling * PHPDoc additions * Fix styling * Update ChangeLog for TypeHintFixes * Fix styling * FilterPillData and StandardFilterPillData phpdocs * Fix styling * Add Wrapper Options to ArrayColumn (#2255) * Add Wrapper Options to FlexCol * Fix styling * Moving getContents Back * Fix styling * Add Docs * Add Wrapper Manual Tests * Fix styling * Update to test separator * Fix styling * Improved pagination UX (#2251) * Link column fix (#2223) (#2224) * Link column fix (#2223) * Add handling for From field for "LinkColumn" * Update ChangeLog * Improved pagination UX --------- Co-authored-by: Joe <[email protected]> * Fixed collapsed function bug with tailwind CSS on mobile version (#2228) * v3.7.2 updates (#2256) --------- Co-authored-by: da-mask <[email protected]> Co-authored-by: G4Zz0L1 <[email protected]> Co-authored-by: Daniel Škopek <[email protected]> Co-authored-by: CarlosChub27 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Tailwind CSS package in mobile mode, when pressing the button to display collapsed items, these items were not displayed correctly. This was due to an issue with the visibility of the items inside the collapsed container.
With the change implemented, I adjusted the visibility settings and behavior of the items when interacting with the button in mobile mode.
All Submissions:
Changes to Core Features: